Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node version to 22 in tests.yaml and package.json and update dependencies #269

Open
wants to merge 5 commits into
base: development/8.1
Choose a base branch
from
Open

Update node version to 22 in tests.yaml and package.json and update dependencies #269

wants to merge 5 commits into from
+2,082 −1,910

Conversation

KillianG
Copy link

@KillianG KillianG commented Nov 4, 2024 •
edited by francoisferrand
Loading

Issue: BKTCLT-33

@bert-e
Copy link
Contributor

bert-e commented Nov 4, 2024

Hello killiang,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@KillianG KillianG force-pushed the improvement/BKTCLT-33-review-and-bump-deps branch from 0b9dc9c to dcb0ebd Compare November 4, 2024 13:47
@scality scality deleted a comment from bert-e Nov 4, 2024
@bert-e
Copy link
Contributor

bert-e commented Nov 4, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

KillianG
KillianG commented Nov 4, 2024
View reviewed changes
package.json Outdated
"arsenal": "git+https://github.com/scality/Arsenal#8.1.87",
"httpagent": "git+https://github.com/scality/httpagent#1.0.5",
"werelogs": "scality/werelogs#8.1.2"
"arsenal": "git+https://github.com/scality/Arsenal#9a6451d247a8c53605e0311b4b3824f2612481eb",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be changed when arsenal is PR merged and release

@francoisferrand francoisferrand changed the title Update node version to 22 in tests.yaml and package.json as long as u… Update node version to 22 in tests.yaml and package.json and update dependencies Nov 6, 2024
francoisferrand
francoisferrand reviewed Nov 6, 2024
View reviewed changes
lib/RESTClient.js Outdated Show resolved Hide resolved
francoisferrand
francoisferrand reviewed Nov 6, 2024
View reviewed changes
lib/shell.js Outdated Show resolved Hide resolved
francoisferrand
francoisferrand reviewed Nov 6, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerkesni Kerkesni Kerkesni approved these changes

@francoisferrand francoisferrand francoisferrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KillianG @bert-e @francoisferrand @Kerkesni